fix(bundler): keep compiled renderer service live - #3690
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe esbuild bundler adds an exported process-liveness helper. The helper treats undefined and null lifecycle fields as active states. A test verifies the behavior for a process with no exit or signal code. ChangesEsbuild service liveness
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to The change narrowly keeps the compiled renderer service live when exit fields are unset and adds regression coverage; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
Fixes compiled renderer startup when the Node-compatible
ChildProcessreportsexitCodeandsignalCodeasundefinedbefore exit. The esbuild adapter previously treated that live service as externally owned, permanently rejecting TSX transforms and returning preview HTTP 500s.Root cause
Staging renderer logs from strict E2E run #31756302514 show project TSX transforms failing with
[ext-bundler-esbuild] Cannot own an esbuild service started outside the module-wide adapter. The production Deno-compiled runtime exposes unset exit fields during service startup; the adapter accepted onlynull.Validation
deno test --no-check --allow-all extensions/ext-bundler-esbuild/src/esbuild-bundler.test.ts— 6 tests / 19 steps passed.deno fmt --checkandgit diff --checkpassed.Validation gap
The local compiled-binary test and repository typecheck are blocked before test execution by the local Deno 2.9.4 runtime lacking the repository-required
node:util/typesbrand checks; CI runs in the supported environment and is the release gate.Summary by CodeRabbit
Bug Fixes
Tests